Db drivers #89
Db drivers #89
Conversation
Fixed BC break in php 5.4. Fixed BC break in php 5.4. Line endings are only LF instead of CRLF. Removed bardumps. Added whitespaces to end of files. Removed all barDumps. Added console as extension to tests because of doctrine dev dependency. Fixed bug in nette database dumper. Added compatibility to nette 2.3. Refactoring. Better abstract classes and deleted unused interface. Refactoring. You can only use one database driver at time. You can use your own loader and dumper. Added updated_at column for invalidating translations. Fixed missing whitespace. Fixed whitespace. Fixed header. Uncommented commit in dumper. Added listener for future use and added mysql queries for creating translation table to dumpers. Fixed whitespace bug in codechecker. cs Added command for creating table. Refactored. Added documentation. Removed commented part of code. Updated documentation. Refactoring. Updated documentation. Small refactoring. Refactoring. Added dependencies to tests. Fixed tabs. Fixed configuration. Fixed configuration. Refactoring. Added test. Hopefully fixed compatibility. bugfix fixed dependency Added table creation. fixed sql data inicialization. Added loader tests. Added another tests. ws fix ws ws fix Added tests. Fixed BC break. fix drobná úprava markdownu v dokumentaci pro lepší čitelnost Fixed column names. opraven composer.json přidána classmap nette db bugfix odebrán Debugger log ugfix for dumping empty domain nette db bugfix fixed invalid insert when message column is not null When no datetime is found in updatedAt column, updated at is datetime with timestamp 0. correct usage of delimiter for databases correct usage of delimiter for databases also in loaders correct usage of delimiter for databases everywhere bugfixes cs added lock typo checking of testing table creation typo typo fixed sqlite compatibility and connection instances in tests removed some debug commands usedParseService instead of self::filterArgs fixed mixed indenting bugfix bugfix for keys where some keys have domain and some do not have domain
| @@ -140,6 +169,10 @@ public function loadConfiguration() | |||
| if ($this->isRegisteredConsoleExtension()) { | |||
| $this->loadConsole($config); | |||
| } | |||
|
|
|||
| foreach ($builder->findByTag(self::DATABASE_LOADER_TAG) as $dbLoader => $true) { | |||
There was a problem hiding this comment.
tady je na to moc brzo
There was a problem hiding this comment.
Rozhodně, tohle má být v beforeCompile.
There was a problem hiding this comment.
hups...to mi nějak uniklo. a proč to má být až v beforecompile?
There was a problem hiding this comment.
Protože v loadConfiguration si extensions registrují services a dávají jim tagy. Tzn. pokud by některé extension bylo registrované až po TranslationExtension a přidalo službu s tímto tagem tak bys o ní nevěděl.
|
In my opinion this shouldn't be a part of Kdyby/Translation directly but a separate package instead like Kdyby/DbTranslation. Kdyby packages are overcomplicated already and I'd rather go the oposite direction and symplify them. |
|
@enumag my thought exactly - that's part of the reason why I haven't continued with this since then. And it should be preferably framework-independent :) |
|
👍 for this PR, would be really nice if kdyby\translation have this feature :) Im looking forward to see this is separate package :) |
|
FYI, once I clear the critical issues with Nette 2.4 compatibility, I intent to make this into a separate package, that would ideally be framework independent. |
|
yes, i am looking for this! |
|
@fprochazka hello, how its going ? |
|
This won't be part of Kdyby/Translation directly and nobody is actively working on this feature as separate package. Feel free to use the code from this PR to create such package. |
[Original #86]