Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual database configuration #8

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbina evgeniy-scherbina commented Jul 17, 2024

PR allows individual database configuration

app.toml example:

[rocksdb]
enable-metrics = true
report-metrics-interval-secs = 15
max-open-files = 16384
...

[rocksdb.blockstore]
max-open-files = -1
block_size = 4096

[rocksdb.tx_index]
max-open-files = -1
block_size = 4096

[rocksdb] section contains default/fallback database configuration, but you can override it with database-specific configuration

it's very convenient approach, because rocksdb configuration is pretty extensive, contains around 30 parameters, but usually we override only few of them

so we can define standard configuration in [rocksdb] section, and then override only few params in database-specific configurations

@evgeniy-scherbina evgeniy-scherbina force-pushed the yevhenii/individual-db-configuration branch from b60ba50 to de55941 Compare July 18, 2024 12:57
@evgeniy-scherbina evgeniy-scherbina force-pushed the yevhenii/individual-db-configuration branch from 4807503 to ea0a341 Compare July 19, 2024 15:10
@evgeniy-scherbina evgeniy-scherbina marked this pull request as ready for review July 19, 2024 15:26
@evgeniy-scherbina evgeniy-scherbina changed the title Added RocksDBOptions struct Allow individual database configuration Jul 19, 2024
@evgeniy-scherbina evgeniy-scherbina force-pushed the yevhenii/individual-db-configuration branch from 6a3fce3 to 3c87345 Compare July 19, 2024 17:26
@evgeniy-scherbina evgeniy-scherbina merged commit a2f11f6 into main Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant