Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty shard routing backend host url map #90

Merged
merged 1 commit into from
Mar 6, 2024
Merged

allow empty shard routing backend host url map #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ func ParseRawProxyBackendHostURLMap(raw string) (map[string]url.URL, error) {
// returning the mapping and error (if any)
func ParseRawShardRoutingBackendHostURLMap(raw string) (map[string]IntervalURLMap, error) {
parsed := make(map[string]IntervalURLMap)
// allow empty shard map (enabled but unused)
if raw == "" {
return parsed, nil
}
hostConfigs := strings.Split(raw, ",")
for _, hc := range hostConfigs {
pieces := strings.Split(hc, ">")
Expand Down
5 changes: 5 additions & 0 deletions config/validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ func TestUnitTestValidateConfigReturnsErrorIfInvaidShardRoutingBackendURLMap(t *
err := config.Validate(testConfig)

assert.NotNil(t, err)

// allow empty
testConfig.ProxyShardBackendHostURLMapRaw = ""
err = config.Validate(testConfig)
assert.NoError(t, err)
}

func TestUnitTestValidateConfigReturnsErrorIfInvalidProxyServicePort(t *testing.T) {
Expand Down
Loading