revert force-set of CORS header on cache misses #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CORs headers are expected to be managed by the backend. However, for cached requests, we want to ensure that CORs is being set properly. This commit reverts setting the CORs header on cache misses. Additionally, it removes the tests that expect a CORs header on cache misses.
pirtleshell
commented
Feb 21, 2024
Comment on lines
-284
to
-288
| // add CORS headers (if not already added) | ||
| accessControlAllowOriginValue := config.GetAccessControlAllowOriginValue(r.Host) | ||
| if w.Header().Get("Access-Control-Allow-Origin") == "" && accessControlAllowOriginValue != "" { | ||
| w.Header().Set("Access-Control-Allow-Origin", accessControlAllowOriginValue) | ||
| } |
There was a problem hiding this comment.
this addition caused the CORs header to be set twice on live deployments (once here, then again from the backend). removing it gives full power to the backend to set all headers.
this is kept for cache hits (the above if block) because we want to ensure correct CORs headers are set for responses that get cached without them. tests are updated to only require CORs header on cache hit tests (locally they do not get the header, but in live deployments nginx sets it).
evgeniy-scherbina
approved these changes
Feb 21, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORs headers are expected to be managed by the backend. However, for cached requests, we want to ensure that CORs is being set properly. This commit reverts setting the CORs header on cache misses. Additionally, it removes the tests that expect a CORs header on cache misses.