handle batch EVM requests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25,
drklee3 and
evgeniy-scherbina
pirtleshell
force-pushed
the
rp-batch-request-processing
branch
from
847d788 to
29004a1
Compare
pirtleshell
force-pushed
the
rp-batch-request-processing
branch
from
29004a1 to
94ec347
Compare
galxy25
reviewed
Feb 7, 2024
galxy25
reviewed
Feb 7, 2024
|
|
||
| // fakeResponseWriter is a custom implementation of http.ResponseWriter that writes all content | ||
| // to a buffer. | ||
| type fakeResponseWriter struct { |
There was a problem hiding this comment.
bufferedResponseWriter a la https://pkg.go.dev/bufio?
There was a problem hiding this comment.
i think that's for buffered read/writing. as in, ensuring writes happen in chunks no bigger than a certain size, not for just writing to a bytes.Buffer. i think the buffering capabilities are overkill for what's needed here
galxy25
reviewed
Feb 7, 2024
galxy25
reviewed
Feb 7, 2024
galxy25
reviewed
Feb 7, 2024
galxy25
approved these changes
Feb 7, 2024
proxy service responds 413 if it receives a request with >ProxyMaximumBatchSize sub-requests
instead of arbitrarily sleeping and praying that the metric was created, wait for the metrics to be created. if the expected metrics are not created, the test will fail with a timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for batch EVM queries.
Batch queries have bodies with a list of
EVMRPCRequestEnvelopes instead of just one. Currently, these fail to decode and then skip the cache, skip metrics, and just get forwarded to the appropriate backend as-is.This PR handles decoding the batch requests and supports getting responses to their sub-requests from the cache. To do this, it adds two new middlewares:
DecodeRequestMiddleware- a rewrite ofRequestLoggingMiddleware. now attempts to parse incoming request as a[]*EVMRPCRequestEnvelopeif it fails to parse as*EVMRPCRequestEnvelope. Forks the middleware sequence if the request is a batchBatchProcessingMiddleware- pulls the batch request out of the context, separates into individual requests that can leverage response caching (and metrics). Then, it concurrently makes the individual requests through the same middleware sequence as the current single request processing. All the individual responses are combined back into a single response to the client.For minimal changes to existing architecture, the BatchProcessingMiddleware just makes use of the exact same middleware sequence as the handling of single requests. Optimizations can be made in the future to recombine sub-requests that will be directed to the same backend if performance is a problem (we have metrics to now to know!). I excluded those changes for now to minimize potential impact to existing single request response flow.
Opening for code review, will not merge until architecture docs have been updated.