Implement caching for cacheable for short time methods #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
yevhenii/cache
branch
2 times, most recently
from
3a64104 to
f79494e
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/cache
branch
from
f79494e to
91164c2
Compare
evgeniy-scherbina
changed the title
galxy25
suggested changes
Nov 15, 2023
galxy25
reviewed
Nov 15, 2023
| @@ -310,6 +312,7 @@ func ReadConfig() Config { | |||
| CacheMethodHasBlockHashParamTTL: time.Duration(EnvOrDefaultInt(CACHE_METHOD_HAS_BLOCK_HASH_PARAM_TTL_ENVIRONMENT_KEY, 0)) * time.Second, | |||
| CacheStaticMethodTTL: time.Duration(EnvOrDefaultInt(CACHE_STATIC_METHOD_TTL_ENVIRONMENT_KEY, 0)) * time.Second, | |||
| CacheMethodHasTxHashParamTTL: time.Duration(EnvOrDefaultInt(CACHE_METHOD_HAS_TX_HASH_PARAM_TTL_ENVIRONMENT_KEY, 0)) * time.Second, | |||
| CacheMethodCacheableForShortTimeTTL: time.Duration(EnvOrDefaultInt(CACHE_METHOD_CACHEABLE_FOR_SHORT_TIME_TTL_ENVIRONMENT_KEY, 0)) * time.Second, | |||
There was a problem hiding this comment.
I think for this (and all other caching ttls, having a non-zero default ttl (say 1 second) makes more sense, otherwise default behavior with zero operator / environment file config is caching is turned off (even if feature flag for caching itself is enabled)
There was a problem hiding this comment.
@galxy25 closing this according to our latest discussion with Kevin and Nick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.