Fix bug with CORS headers #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
yevhenii/cache-fix
branch
3 times, most recently
from
5961b65 to
b48a181
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/cache-fix
branch
2 times, most recently
from
07edcdd to
f060113
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/cache-fix
branch
from
f060113 to
16cea28
Compare
galxy25
reviewed
Nov 3, 2023
| DEFAULT_ACCESS_CONTROL_ALLOW_ORIGIN_VALUE="*" | ||
| # Map contains mapping between hostname (for ex. evm.kava.io) and corresponding value for Access-Control-Allow-Origin header. | ||
| # If hostname for specific request is missing we fallback to DEFAULT_ACCESS_CONTROL_ALLOW_ORIGIN_VALUE. | ||
| # NOTE: it will be used only in Cache Hit scenario. |
There was a problem hiding this comment.
please update caching docs with details on how the cachng middleware affects headers and logic for deciding when to modify cors headers
galxy25
reviewed
Nov 3, 2023
| @@ -254,6 +254,11 @@ func createProxyRequestMiddleware(next http.Handler, config config.Config, servi | |||
| for headerName, headerValue := range typedCachedResponse.HeaderMap { | |||
| w.Header().Add(headerName, headerValue) | |||
| } | |||
| // add CORS headers | |||
| accessControlAllowOriginValue := config.GetAccessControlAllowOriginValue(r.Host) | |||
| if accessControlAllowOriginValue != "" { | |||
There was a problem hiding this comment.
important to add to the spec in the caching doc that we won't override any value of this header if present from the backend response
There was a problem hiding this comment.
actually in current implementation we override
I can add smth like this:
// add CORS headers
accessControlAllowOriginValue := config.GetAccessControlAllowOriginValue(r.Host)
if w.Header().Get("Access-Control-Allow-Origin") == "" && accessControlAllowOriginValue != "" {
w.Header().Add("Access-Control-Allow-Origin", accessControlAllowOriginValue)
}@galxy25 ?
galxy25
approved these changes
Nov 3, 2023
evgeniy-scherbina
force-pushed
the
yevhenii/cache-fix
branch
from
d3e4dd2 to
5663879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.