improve & refactor evm_rpc methods for reuse #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will need the validation and block number extraction for height-based routing. however, it will be in the critical path, so we need to not have the bit that makes an additional evm request.
some methods will always work if routed to a pruning cluster. do that!
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25,
drklee3 and
evgeniy-scherbina
galxy25
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a sharding setup that routes requests for latest blocks (and other calls that can be made with no historical data) to a configurable pruning cluster.
In order to make that code more easily reviewable (and give me more time to write documentation 😄), I've pulled out all the changes I made to the decode package.
changes
"finalized"and"safe"block tagsnullis passed as a block number. this is undefined behavior in the spec, but is regularly interpreted by clients to mean "latest". instead of erroring because it can't convertnilto a string, the block number parsing now encodes it to a special value so we can track requests made with no value in the block number param position in metricsNoHistoryMethods