fix failing & add test coverage reporting #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
commented
Sep 21, 2023
Comment on lines
-22
to
-26
| requestBlockNumber, valid := cosmosmath.NewIntFromString(requestedBlockNumberHexEncoding) | ||
|
|
||
| if !valid { | ||
| t.Fatalf("failed to convert %s to cosmos sdk int", requestedBlockNumberHexEncoding) | ||
| } |
There was a problem hiding this comment.
@galxy25, let me know if this deleted code was an important condition of this test.
AFAICT, it is not.
the sdkmath parsing resulted in a test failure:
=== RUN TestUnitTestExtractBlockNumberFromEVMRPCRequestReturnsExpectedBlockForValidRequest
evm_rpc_test.go:39:
Error Trace: /Users/pirtle/projects/kava/kava-proxy-service/decode/evm_rpc_test.go:39
Error: Not equal:
expected: math.Int(math.Int{i:(*big.Int)(0xc00017d780)})
actual : int64(2)
Test: TestUnitTestExtractBlockNumberFromEVMRPCRequestReturnsExpectedBlockForValidRequest
NewIntFromString("0x2") is 824635283328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting acquainted with the codebase to start working on node sharding, I noticed some tests that weren't covered by
make testbecause the test methods don't begin withTestUnitTest.make testto run all tests, even if they aren't prefixed withTestUnitTestorTestE2ETest