Skip to content

Commit

Permalink
allow empty shard routing backend host url map
Browse files Browse the repository at this point in the history
  • Loading branch information
pirtleshell committed Mar 6, 2024
1 parent e30b255 commit b374753
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ func ParseRawProxyBackendHostURLMap(raw string) (map[string]url.URL, error) {
// returning the mapping and error (if any)
func ParseRawShardRoutingBackendHostURLMap(raw string) (map[string]IntervalURLMap, error) {
parsed := make(map[string]IntervalURLMap)
// allow empty shard map (enabled but unused)
if raw == "" {
return parsed, nil
}
hostConfigs := strings.Split(raw, ",")
for _, hc := range hostConfigs {
pieces := strings.Split(hc, ">")
Expand Down
5 changes: 5 additions & 0 deletions config/validate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ func TestUnitTestValidateConfigReturnsErrorIfInvaidShardRoutingBackendURLMap(t *
err := config.Validate(testConfig)

assert.NotNil(t, err)

// allow empty
testConfig.ProxyShardBackendHostURLMapRaw = ""
err = config.Validate(testConfig)
assert.NoError(t, err)
}

func TestUnitTestValidateConfigReturnsErrorIfInvalidProxyServicePort(t *testing.T) {
Expand Down

0 comments on commit b374753

Please sign in to comment.