Skip to content

Commit

Permalink
feat: add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
boodyvo committed Sep 16, 2024
1 parent c242326 commit 9220e53
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ METRIC_PRUNING_MAX_REQUEST_METRICS_HISTORY_DAYS=45
# If we use metric database. If set to false,
# all metric collection and connection to the DB would be disabled
# and the service would run without any metrics.
METRIC_DATABASE_ENABLED=${METRIC_DATABASE_ENABLED:-true}
METRIC_DATABASE_ENABLED=${METRIC_DATABASE_ENABLED}
# CACHE_ENABLED specifies if cache should be enabled. By default cache is disabled.
CACHE_ENABLED=true
# REDIS_ENDPOINT_URL is an url of redis
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/ci-e2e-no-metrics-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ jobs:
- name: pull pre-built images
run: sudo docker compose -f ci.docker-compose.yml pull
- name: build and start proxy service and it's dependencies
run: METRIC_DATABASE_ENABLED=false sudo docker compose -f ci.docker-compose.yml up -d --build proxy redis
# We need to provide additional env file to override the METRIC_DATABASE_ENABLED variable, not via env variable.
# Mentioned here: https://github.com/docker/compose/issues/9737
run: sudo docker compose -f ci.docker-compose.yml up -d --build proxy redis
env:
METRIC_DATABASE_ENABLED: "false"
- name: wait for proxy service to be running
Expand Down

0 comments on commit 9220e53

Please sign in to comment.