Skip to content

Commit

Permalink
feat: updates for the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
boodyvo committed Sep 12, 2024
1 parent 44cb8a9 commit 60e55ed
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/ci-e2e-no-metrics-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@ jobs:
cache: true
- name: pull pre-built images
run: sudo docker compose -f ci.docker-compose-no-metrics.yml pull
# In this step, this action saves a list of existing images,
# the cache is created without them in the post run.
# It also restores the cache if it exists.
# TODO(yevhenii): this step failed with "No space left on device" error, debug it and enable back
# - name: cache docker images
# uses: satackey/[email protected]
# Ignore the failure of a step and avoid terminating the job.
continue-on-error: true
- name: build and start proxy service and it's dependencies
run: sudo docker compose -f ci.docker-compose-no-metrics.yml up -d --build
- name: wait for proxy service to be running
Expand Down
6 changes: 3 additions & 3 deletions clients/database/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type PostgresDatabaseConfig struct {
DatabaseUsername string
DatabasePassword string
ReadTimeoutSeconds int64
WriteTimeoutsSeconds int64
WriteTimeoutSeconds int64
DatabaseMaxIdleConnections int64
DatabaseConnectionMaxIdleSeconds int64
DatabaseMaxOpenConnections int64
Expand Down Expand Up @@ -64,7 +64,7 @@ func NewPostgresClient(config PostgresDatabaseConfig) (PostgresClient, error) {
pgdriver.WithPassword(config.DatabasePassword),
pgdriver.WithDatabase(config.DatabaseName),
pgdriver.WithReadTimeout(time.Second*time.Duration(config.ReadTimeoutSeconds)),
pgdriver.WithWriteTimeout(time.Second*time.Duration(config.WriteTimeoutsSeconds)),
pgdriver.WithWriteTimeout(time.Second*time.Duration(config.WriteTimeoutSeconds)),
)
} else {
pgOptions = pgdriver.NewConnector(
Expand All @@ -74,7 +74,7 @@ func NewPostgresClient(config PostgresDatabaseConfig) (PostgresClient, error) {
pgdriver.WithPassword(config.DatabasePassword),
pgdriver.WithDatabase(config.DatabaseName),
pgdriver.WithReadTimeout(time.Second*time.Duration(config.ReadTimeoutSeconds)),
pgdriver.WithWriteTimeout(time.Second*time.Duration(config.WriteTimeoutsSeconds)),
pgdriver.WithWriteTimeout(time.Second*time.Duration(config.WriteTimeoutSeconds)),
)
}

Expand Down
2 changes: 1 addition & 1 deletion service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func createDatabaseClient(ctx context.Context, config config.Config, logger *log
SSLEnabled: config.DatabaseSSLEnabled,
QueryLoggingEnabled: config.DatabaseQueryLoggingEnabled,
ReadTimeoutSeconds: config.DatabaseReadTimeoutSeconds,
WriteTimeoutsSeconds: config.DatabaseWriteTimeoutSeconds,
WriteTimeoutSeconds: config.DatabaseWriteTimeoutSeconds,
DatabaseMaxIdleConnections: config.DatabaseMaxIdleConnections,
DatabaseConnectionMaxIdleSeconds: config.DatabaseConnectionMaxIdleSeconds,
DatabaseMaxOpenConnections: config.DatabaseMaxOpenConnections,
Expand Down

0 comments on commit 60e55ed

Please sign in to comment.