[WILL NOT BE MERGED] Kava cosmos v50 test patched #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DracoLi
reviewed
Oct 24, 2024
| @@ -595,7 +595,7 @@ the Tracer type used to collect execution traces from the EVM transaction execut | |||
|
|
|||
| * (proto) [tharsis#448](https://github.com/evmos/ethermint/pull/448) Bump version for all Ethermint messages to `v1` | |||
| * (server) [tharsis#434](https://github.com/evmos/ethermint/pull/434) `evm-rpc` flags and app config have been renamed to `json-rpc`. | |||
| * (proto, evm) [tharsis#207](https://github.com/evmos/ethermint/issues/207) Replace `big.Int` in favor of `sdk.Int` for `TxData` fields | |||
| * (proto, evm) [tharsis#207](https://github.com/evmos/ethermint/issues/207) Replace `big.Int` in favor of `sdkmath.Int` for `TxData` fields | |||
| @@ -16,10 +16,11 @@ | |||
| package ante | |||
|
|
|||
| import ( | |||
| sdkstore "cosmossdk.io/store/types" | |||
There was a problem hiding this comment.
nit: should consider using storetypes "cosmossdk.io/store/types" since that seems to be the standard in the cosmos sdk.
| @@ -233,7 +237,7 @@ func VerifySignature( | |||
| Gas: tx.GetGas(), | |||
| }, | |||
| msgs, tx.GetMemo(), | |||
| tx.GetTip(), | |||
| // tx.TipTx interface was removed, added types.TxWithTimeoutHeight, they have been deprecated and should not be used since v0.46.0 | |||
There was a problem hiding this comment.
This relates to our eip712 signature validation so will need a more thorough review to ensure nothing breaks. On first look, I don't think is will break eip712 but we should definitely note to test this more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test update for cosmos-sdk v0.50.10