Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import opendb and adjust dependencies accordingly #63

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Import opendb and adjust dependencies accordingly #63

merged 5 commits into from
Jul 3, 2024

Conversation

evgeniy-scherbina
Copy link

@evgeniy-scherbina evgeniy-scherbina commented Jun 24, 2024 •
edited
Loading

Dependency changes:

  • import github.com/Kava-Labs/opendb module
  • upgrade github.com/cosmos/iavl: v1.0.0 -> v1.1.2
    • because opendb depends on v1.1.2, so following MVS - ethermint also depends on v1.1.2
    • NOTE: iavl v1.0.0 is retracted
  • upgrade github.com/kava-labs/cosmos-sdk dependency: v0.47.10-kava.2 -> v0.47.10-iavl-v1-kava.1
    • difference between versions: Kava-Labs/cosmos-sdk@3d565b7
    • it's needed to adjust to the iavl changes
    • v0.47.10-iavl-v1-kava.1 is used in kava

Source code changes:

  • use opendb.OpenDB instead of dbm.NewDB in few places

Related PR: Kava-Labs/opendb#4

@evgeniy-scherbina evgeniy-scherbina force-pushed the yevhenii/rocksdb-metrics branch 4 times, most recently from 030fa1e to ded6cc6 Compare June 24, 2024 19:15
@evgeniy-scherbina evgeniy-scherbina changed the title Copy opendb package from kava Tmp Commit Jun 24, 2024
@evgeniy-scherbina evgeniy-scherbina changed the title Tmp Commit Import opendb and adjust dependencies accordingly Jun 27, 2024
@evgeniy-scherbina evgeniy-scherbina changed the base branch from main to kava/release/v0.26.x June 27, 2024 17:56
@evgeniy-scherbina evgeniy-scherbina force-pushed the yevhenii/rocksdb-metrics branch 2 times, most recently from 2487be9 to 3c3a5b3 Compare July 2, 2024 16:12
@evgeniy-scherbina evgeniy-scherbina marked this pull request as ready for review July 2, 2024 16:28
@evgeniy-scherbina evgeniy-scherbina mentioned this pull request Jul 2, 2024
Merged
@evgeniy-scherbina evgeniy-scherbina changed the base branch from kava/release/v0.26.x to main July 2, 2024 16:51
karzak
karzak approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@karzak karzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - couldn't think of any units tests needed immediately, but will be good to add some end-to-end tests around metrics once wired up to kava

@evgeniy-scherbina evgeniy-scherbina merged commit badab86 into main Jul 3, 2024
25 checks passed
@evgeniy-scherbina evgeniy-scherbina deleted the yevhenii/rocksdb-metrics branch July 16, 2024 12:58
@evgeniy-scherbina evgeniy-scherbina mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karzak karzak karzak approved these changes

@pirtleshell pirtleshell Awaiting requested review from pirtleshell

@nddeluca nddeluca Awaiting requested review from nddeluca

Assignees
No one assigned
Labels
backport/all backport/v0.26
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeniy-scherbina @karzak