New versions of gmail don't have that table anymore #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there and thanks for the patch! I've tested the existing version on my free grandfathered "legacy" GSuite account, and the existing code seems to work fine there, at least for me. Maybe the best approach would be to combine the two checks into one, just to be sure it keeps on working equally well for everyone? Could you update your PR to do that instead? If you do that, I'll merge and push a new version to npmjs. |
|
Ive retested, and now this code is the only one which works on plain gmail.com accounts and my grandfathered Google apps account. Consider this good enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to discuss