Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish and Spanish Latam Translation V1 #68

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Happyuky7
Copy link

The traditions are already there, only the ".meta" files are missing.

@Kariaro Kariaro changed the base branch from main to develop March 1, 2023 21:09
@Kariaro
Copy link
Owner

Kariaro commented Mar 2, 2023

I don't know Spanish myself but I have some questions :3

  1. In es_419.lang and es_ES.lang on line 27 camera is spelled Camara and on the next line it's spelled Cámara

    Is this a typo or intentional?

  2. On line 21 in both files the translation ends with Please check me out.

    Was this intentional?

@Happyuky7
Copy link
Author

Happyuky7 commented Mar 2, 2023

Nothing was intentional, they were mistakes on my part that I didn't notice when I did the translation the first time, I have corrected them and also added a few things to make certain functions more understandable.

On line 21 I didn't see that I already had the "\n" and I left the word out, sorry.

That's also partly why I put V1 in case I missed something by accident.

:3

@Kariaro
Copy link
Owner

Kariaro commented Mar 2, 2023

Line 26 and 63 in both files has a trailing dot. Remove it

Other than that everything else looks good 👍

@Happyuky7
Copy link
Author

Done! 👍

@Kariaro
Copy link
Owner

Kariaro commented Mar 6, 2023

There is a type in the file name en_ES.lang should be es_ES.lang
I get errors when I try the languages in the app

es_419.lang has no problems and works 👍

@Kariaro
Copy link
Owner

Kariaro commented Mar 6, 2023

bild

The tool tip text might be a bit to small in the help text window. Could you remove the left click part or simplify it?

@Kariaro Kariaro mentioned this pull request Mar 6, 2023
@Kariaro Kariaro changed the base branch from develop to feature/workflow-fix March 6, 2023 13:12
@Kariaro Kariaro changed the base branch from feature/workflow-fix to develop March 6, 2023 13:17
@Kariaro
Copy link
Owner

Kariaro commented Mar 6, 2023

Ignore the failing workflow checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants