Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting multi dataset #351

Closed
wants to merge 33 commits into from
Closed

feat: supporting multi dataset #351

wants to merge 33 commits into from

Conversation

islxyqwe
Copy link
Member

TODO: check all features working in multi dataset & single dataset.

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphic-walker ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 7:24am

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Risk Level 3 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/renderer/index.tsx

  1. The useEffect hook at the end of the file has a dependency on isSpatial and vizStore, but these are not included in the dependency array. This could lead to unexpected behavior. Include isSpatial and vizStore in the dependency array of the useEffect hook.
useEffect(() => {
    // ... existing code ...
}, [isSpatial, vizStore]);
  1. The handleGeomClick function is quite complex and could benefit from being broken down into smaller, more manageable functions. This would improve readability and maintainability of the code. Consider refactoring this function to simplify its logic.

Risk Level 3 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/computation/clientComputation.ts

There is a potential issue with the filter case in the switch statement. The map function is used but the returned value is not used. This could lead to unexpected behavior. Consider removing the map function or use the returned value.

case 'filter': {
    res = await applyFilter(
        res,
        step.filters
            .filter(Boolean)
    );
    break;
}

Risk Level 3 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/lib/insights/explainBySelection.ts

The explainBySelection function is quite large and complex. It could be broken down into smaller, more manageable functions to improve readability and maintainability. For example, the logic inside the for loop could be extracted into a separate function.

Also, the function is directly using the dataQuery function. This could make testing this function in isolation difficult. Consider passing the dataQuery function as a parameter to the explainBySelection function.


🔍🔄🧩


Powered by Code Review GPT

* chore: reduce unneed computation

* fix: show table summary is not reactive

* fix: field position & reactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant