Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styled the new contests page #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NikhilSharmaWe
Copy link

What's this PR do? (related issue if exists)

it styles the new contests page

Any context you want to provide on the implementation?

Screenshots? (necessary if an UI/UX change)

@Signior-X
Copy link
Member

@NikhilSharmaWe Thanks for working on this!

It would be better if you attach some screenshots, in the PR itself.

Copy link
Member

@Signior-X Signior-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you tried!
And you know how to write, just a better color scheme and look will be highly appreciated.

Looking for the changes soon!

@@ -1,3 +1,4 @@
import "./contests.css".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not import any css in the models
This is just the mongodb model.

Also I think there no any contests.css so remove this from here.

}


</style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles you added here doesn't look good or match with the Theme.
You could have tried to add colors in the whole inner box and giving a brown background at the heading makes it ugly.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try to make it center and instead of using different colors, try using the same color scheme with different contrast.

Yellow somewhere blue somewhere brown doesn't look good.
I hope you get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants