Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Memes and added Meaningful photos #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kartik1000
Copy link
Contributor

Description

Removed Memes and added Contest related pictures which are relatively more meaningful.

Fixes #73

@kpbot kpbot added the size: S label Jul 6, 2019
@kpbot
Copy link
Member

kpbot commented Jul 6, 2019

Hello @kartik1000, it seems like you have referenced #73 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #73..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: kpbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to KamandPrompt!

Copy link
Member

@Vishal1541 Vishal1541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, @kartik1000 these banners do look nice but wouldn't be better if our college's previous (+ upcoming if any) hosted events banners is there instead of other platform's events. After all it's all for our college. @aashish-ak your views?

@Vishal1541 Vishal1541 requested review from aashish-ak and removed request for aashish-ak July 7, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the display images.
3 participants