Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix story cards without encounter_code #1081

Closed
wants to merge 4 commits into from
Closed

Fix story cards without encounter_code #1081

wants to merge 4 commits into from

Conversation

boutchitos
Copy link
Contributor

I fix validator.py :

  • It validates a story card has an encounter_code
  • It fix (with --fix_formatting) story card without encounter_code by setting it from the previous scanned cards.

Related to issues:
#1075
#983 (encounter_code only, I did not fix the images).

Needs this issue/PR approuved to get validation of encounter cards: #1077

I did not push the result of running python validate.py --fix_formatting as I can't fallback on the proper JSON formatting. So I went up modifying all the json files. How should I format files? I'm confused about validate.py formating and prettier (in package.json).

@boutchitos boutchitos closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant