Fix validate_card is not called for encounter cards in validate.py #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May be related to version's packages, but just running the command: `python validate.py --fix_formatting` modifies all the json files. This is the results: - mostly whitespaces - attributes ordering My packages : $ pip list Package Version ---------- ------- attrs 21.4.0 jsonschema 4.3.2 pip 21.3.1 pyrsistent 0.18.0 setuptools 57.4.0
Ran: yarn install yarn prettier yarn prettier:check
Fix/validate formats all json Workflow is green!
Implied fields are now logged.
Also fix cards directly removing like sanity: null.
|
I pushed too much on the branch's PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1077