Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Feature : PeopleListPage 구현 #38

Closed
wants to merge 9 commits into from

Conversation

Goldchae
Copy link
Member

@Goldchae Goldchae commented Aug 16, 2024

🔍 What is the PR?

PeopleListPage 만들었어요
미니레이아웃, 카드 컴포넌트 만들었어용

📸 Screenshot

스크린샷 2024-08-16 오후 6 17 03

🙏 To Reviewers

miniLayout props로 위 제목과 크기 지정해서 여러 데에서 쓸 수 있게 만들어서 common에 넣었어용
등장하는 데가 많아서 이거 다 사용하시면 될 것 같아여

컴포넌트 선택자 같은 고급 기능 쓰려면 바벨이나 swc 플러그인 깔아야 한대서 바벨 쓰는 걸로 vite 컨피그 고쳣어용

✅ Check List

  • Merge 하는 브랜치가 올바른가?
  • 코딩 컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?
  • 내 코드에 대한 자기 검토가 되었는가?

💭 Related Issues

@sayyyho sayyyho changed the title ✨Feature : PeopleListPage 만들 ✨Feature : PeopleListPage 구현 Aug 19, 2024
@sayyyho sayyyho closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] PeopleListComponents 관련 컴포넌트들 + 페이지 구현
2 participants