fix issues in course analysis statistics tool #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seStatisticsAsync one step up in react tree
…gic. The main changes are: - faulty week logic for determining semester is removed and only now semester from Kopps is used. - only one semester can be selected, to avoid issues of added same course offering multiple time. - ST is removed, course offerings will be included in HT och VT depending on semester from Kopps (ST was caluclated from weeks before and is no actual semester)
karlandindrakryggen
force-pushed
the
issues/KUI-1585-course-analysis-statistics
branch
from
46364cd
to
7277aa6
Compare
| chosenSchool = '', | ||
| language = 'sv' | ||
| ) { | ||
| function filterOfferingsForAnalysis(courses = [], chosenSemester, chosenSchool = '', language = 'sv') { |
There was a problem hiding this comment.
Most notable changes are in this function.
karlandindrakryggen
requested review from
belanglos,
amirhossein-haerian,
axelbjo and
allazis
as code owners
axelbjo
approved these changes
Nov 13, 2024
allazis
approved these changes
Nov 13, 2024
amirhossein-haerian
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes that addresses reported issue:
The PR aslo include some other fixes for different warnings:
<StatisticsAlert>throughdocument.getElementById()andcreateRoot()to by moving useStatisticsAsync one step up in react tree and rendering it the normal React way