Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always report Scheduler abort reasons to Discord #348

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

HebaruSan
Copy link
Member

Motivation

The Scheduler is having some outages at the moment, and it's not clear why. We get a few messages in Discord about the GitHub API limit, but then it just goes silent. Meanwhile @techman83 can see stuff like this in the admin screens somewhere:

[2024-10-31 00:09:37,857] [INFO    ] Run skipped, below cpu credit target (Current Avg: 91)
[2024-10-31 00:09:38,212] [INFO    ] Run skipped, below cpu credit target (Current Avg: 91)

Changes

  • Now all of the Scheduler's abort reasons are upgraded from logging.info to logging.error so we can tell what's happening without accessing the admin side.
  • Now those messages always report which game is being skipped, so we can more easily see which ones are duplicates
  • Now those messages also report the limit against which the value is being compared, to give a sense of how bad a problem is and how close it is to self-resolving

@HebaruSan HebaruSan added Enhancement New feature or request good first issue Good for newcomers Scheduler Adds netkans to the queue to be inflated labels Oct 31, 2024
@HebaruSan HebaruSan force-pushed the feature/scheduler-skip-reasons branch from 851d74d to a2d923d Compare October 31, 2024 21:15
@HebaruSan HebaruSan merged commit 2045c78 into KSP-CKAN:master Oct 31, 2024
3 checks passed
@HebaruSan HebaruSan deleted the feature/scheduler-skip-reasons branch October 31, 2024 21:18
@HebaruSan
Copy link
Member Author

It's CPU credits again:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request good first issue Good for newcomers Scheduler Adds netkans to the queue to be inflated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant