-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obey system colors for dark theme support #2937
Conversation
b65970a
to
0ed238e
Compare
I guess .NET considers the tab's "bounds" to be the space inside the border, while Mono considers it to include the border? Fix pushed, need to test in Windows. Hopefully we don't have to put |
Yup, offsetting down by 1 worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay again now.
Did not test on Windows, but your screenshots on W7 look good.
According to this article, W10 users have to do some registry editing to change the colours: https://winaero.com/blog/change-window-background-color-in-windows-10/
Maybe someone will try it out one day and report if it works too.
Problem
You can configure the legacy system colors on Windows to change how WinForms apps display. In Windows 7:
CKAN doesn't look very good in this mode:
Note that it looks OK if you choose one of the more extreme "high contrast" themes, but these also change your window borders and everything else, so it's not a great solution:
Causes
Changes
ThemedListView
andThemedTabControl
classes are created as drop-in replacements forListView
andTabControl
but tweaked to obey system colorsThis makes dark themes on Windows look better:
It also results in a minor degradation of appearance in a normal theme because the gradients for inactive tabs and list headers are suppressed:
Needs to be tested on Linux. I think it should look the same, but there could be surprises.
Fixes #2881.