Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put client library hashes in a single package #775

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Put client library hashes in a single package #775

wants to merge 1 commit into from

Conversation

kaol
Copy link
Contributor

@kaol kaol commented Oct 8, 2021

Let's see if using spago for the local dependency package works.

@kaol kaol force-pushed the feature/common-apis-package branch from 858eed4 to 7ac9b5f Compare October 8, 2021 08:20
@kaol kaol marked this pull request as draft October 8, 2021 08:38
@kaol kaol force-pushed the feature/common-apis-package branch 2 times, most recently from 04b7a0b to 6b298e6 Compare October 8, 2021 11:08
@kaol kaol force-pushed the feature/common-apis-package branch from 6b298e6 to c1d3df7 Compare October 8, 2021 12:38
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Deploy previews are ready 😎

@vapaj
Copy link
Contributor

vapaj commented Dec 2, 2021

Do we need to move LocalStorage and Cusno modules under apis? Also Lettera probably should be there too.

@kaol
Copy link
Contributor Author

kaol commented Dec 2, 2021

Do we need to move LocalStorage and Cusno modules under apis? Also Lettera probably should be there too.

Persona and KSF.Api.Subscription pulled Cusno with them. Persona requires LocalStorage.

The modules in apis are all related to using the generated client libraries and we aren't using one for Lettera, so it wouldn't follow from that. But this branch is quite old, I'd have to check again. It wouldn't likely hurt to move it in either case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaol @vapaj