Eslint and prettier #1407
Open
Eslint and prettier #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy previews are ready 😎 |
|
Most of this PR is just line noise from |
| @@ -20,9 +20,7 @@ class Content extends Component { | |||
| if (blockType === "ad") { | |||
| return this.renderAd(block, key); | |||
| } | |||
| if (blockType === "paragraph") { | |||
| return this.renderParagraph(block, key); | |||
| } else if (blockType === "headline") { | |||
There was a problem hiding this comment.
One of the very few non-formatter changes: htmlToReactParser is always undefined in the renderParagraph function, so calling renderParagraph would always fail -- since it hasn't been a problem, we aren't rendering any blocks with the type being paragraph.
| @@ -2,15 +2,10 @@ import React from "react"; | |||
| import ReactDOM from "react-dom"; | |||
| import "basscss/css/basscss-cp.css"; | |||
|
|
|||
| // yup, welcome to react 16 | |||
| import createReactClass from "create-react-class"; | |||
| React.createClass = createReactClass; | |||
There was a problem hiding this comment.
A handful of services define createClass in their index.js files. None of the generated code refers to that function.
|
All of the other non-formatting changes should be just unused imports / variables / parameters. |
jllang
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.