Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザープロフィールページの作成 #8

Merged
merged 20 commits into from
Sep 20, 2023
Merged

ユーザープロフィールページの作成 #8

merged 20 commits into from
Sep 20, 2023

Conversation

KOH6
Copy link
Owner

@KOH6 KOH6 commented Sep 19, 2023

課題のリンク

やったこと

  • ユーザープロフィールページの作成を行いました。

動作確認方法

その他

@KOH6 KOH6 self-assigned this Sep 19, 2023
Copy link
Collaborator

@yamaryo416 yamaryo416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


private

def attach_dummy_photo(user)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おそらく、

def attach_dummy_photo
  unless photo.attached?
  ...
end

みたいな形で、インスタンス変数なので、
引数なしで、行けるはず。

before_save :attach_dummy_photo

とかける

@github-actions
Copy link

1 Error
🚫 reviewersを指定して下さい

Generated by 🚫 Danger

@KOH6
Copy link
Owner Author

KOH6 commented Sep 20, 2023

ありがとうございます!コメントいただいた点を修正してマージいたします!

@KOH6 KOH6 merged commit e3f711a into main Sep 20, 2023
6 checks passed
@KOH6 KOH6 deleted the profile branch September 20, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants