Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プロフィール編集画面 #10

Merged
merged 8 commits into from
Sep 21, 2023

rails_best_practices対応

ab23c5b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

プロフィール編集画面 #10

rails_best_practices対応
ab23c5b
Select commit
Loading
Failed to load commit list.
GitHub Actions / rails_best_practices completed Sep 20, 2023 in 0s

reviewdog [rails_best_practices] report

reported by reviewdog 🐶

Findings (3)

app/views/kaminari/_paginator.html.slim|7| move code into model (page use_count > 2)
app/controllers/users_controller.rb|4| move model logic into model (@user use_count > 4)
app/controllers/users_controller.rb|13| use scope access

Filtered Findings (0)

Annotations

Check notice on line 7 in app/views/kaminari/_paginator.html.slim

See this annotation in the file changed.

@github-actions github-actions / rails_best_practices

[rails_best_practices] app/views/kaminari/_paginator.html.slim#L7

move code into model (page use_count > 2)
Raw output
/home/runner/work/twitter_clone/twitter_clone/app/views/kaminari/_paginator.html.slim:7 - move code into model (page use_count > 2)

Check notice on line 4 in app/controllers/users_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rails_best_practices

[rails_best_practices] app/controllers/users_controller.rb#L4

move model logic into model (@user use_count > 4)
Raw output
/home/runner/work/twitter_clone/twitter_clone/app/controllers/users_controller.rb:4 - move model logic into model (@user use_count > 4)

Check notice on line 13 in app/controllers/users_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rails_best_practices

[rails_best_practices] app/controllers/users_controller.rb#L13

use scope access
Raw output
/home/runner/work/twitter_clone/twitter_clone/app/controllers/users_controller.rb:13 - use scope access