Feature/multiple items in area #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
January 25, 2021 11:17
This currently causes errors as it will try to deserialize the whole grid json into IEnumerable<StackItem> which will crash. As Bento is meant to be replacing grid I'm not sure why there is a GridEditor component but we should look at working with the grid json correctly.
…multiple items in an area Created new AreaItem and added List to Area (along with SettingsData for future Area settings), leaving original properties on Area for BentoItem and backwards compatibility. Updated ValueConverter(s) and ContentServiceEvent to work with new AreaItem.
…code We can use alias of Control.Editor to match against "bentoGridItem" then parse value accordingly.
Creating new Data Type to allow multiple Items without altering "Bento Item" (to preserve backwards compatibiility with existing properties that may have been created).
Move some code into resource.js so it only has to be in one place, move the bento-picker buttons into their own directive so they can sit outside of the item content block.
Create Multi Item data type within umbraco for testing, and assign to a property on Home doc type. Also, coudn't log in to back office so used the 0.0.26 db file and went through the update process which seems to have fixed it.
Start to rework the angular and views to work with an arrays of items, instead of a singular item, within the area.
All backoffice components being updated to convert single items to multiple (and, in the case of the Benti Item data type, back again).
…o data Also update to the backoffice css so that the tools are in the right place and the right colour.
Also update delete message used by area
… correct allowances We can remove the commented out code once we're happy it isn't used anywhere else
Items will need their own drag and drop code
Also fix to editor controller for dealing with Multi on $scope.model.value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows issue #21 and allows the adding of multiple Items under an Area.
Hopefully without breaking anything from earlier versions.