Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/42 deal page #52

Merged
merged 15 commits into from
Jun 8, 2024
Merged

Feat/42 deal page #52

merged 15 commits into from
Jun 8, 2024

Conversation

eastfilmm
Copy link
Contributor

✨ 작업 내용


스크린샷 2024-06-08 오후 4 17 57 deal page 동작 확인 완료 스크린샷 2024-06-08 오후 4 19 17 deal detail 동작 확인 완료 기존의 slider 에서 navigate 로 deal detial page 로 이동했던 것을 모달창으로 변경함

✨ 참고 사항


api return data 변경 예정이라 추후 코드 수정 필요
dela detail 추가 수정 필요

⏰ 현재 버그


✏ Git Close

close #42

@eastfilmm eastfilmm added ✨ Feature 기능 추가 💄 Design 프론트엔드 CSS 관련 이슈 👽 API 비동기 통신 코드를 짜는 경우, 백엔드와의 통신하는 경우 labels Jun 8, 2024
@eastfilmm eastfilmm requested a review from KimKyuHoi June 8, 2024 07:20
@eastfilmm eastfilmm self-assigned this Jun 8, 2024
Copy link
Contributor

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM

@eastfilmm eastfilmm merged commit 8cd5a88 into develop Jun 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👽 API 비동기 통신 코드를 짜는 경우, 백엔드와의 통신하는 경우 💄 Design 프론트엔드 CSS 관련 이슈 ✨ Feature 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants