Upgrade to ZIO 2 #48
Upgrade to ZIO 2 #48
Conversation
octavz
requested review from
LeonDaniel and
cipriansofronia
and removed request for
LeonDaniel
| @@ -22,7 +21,6 @@ object KafkaExplorerSpec extends DefaultRunnableSpec: | |||
|
|
|||
| val layer = | |||
| Clock.live >+> | |||
| Blocking.live >+> | |||
| itlayers.kafkaContainer >+> | |||
There was a problem hiding this comment.
Shouldn't we skip over composing layers live this and use the ZLayer.make with automatic injection?
| @@ -16,19 +15,19 @@ import org.apache.kafka.clients.consumer.OffsetResetStrategy | |||
|
|
|||
| object KafkaProducerSpec extends DefaultRunnableSpec: | |||
|
|
|||
| private val consumerLayer: ZLayer[Has[KafkaContainer], Nothing, Has[KafkaConsumer]] = | |||
| Clock.live ++ Blocking.live ++ itlayers.clusterConfig(clusterId = "cluster_id") >>> KafkaConsumer.liveLayer | |||
| private val consumerLayer: ZLayer[KafkaContainer, Nothing, KafkaConsumer] = | |||
There was a problem hiding this comment.
The same comment here: should we try automatic layer creation without operators?
There was a problem hiding this comment.
not sure why would that be necessary, if possible I would use operators to speed up compile time
| @@ -31,10 +30,10 @@ object itlayers: | |||
| ) | |||
| .toManaged_ | |||
|
|
|||
| def consumerLayer(cgroup: String): ZLayer[Has[KafkaContainer] with Clock with Blocking, Nothing, Has[Consumer]] = | |||
| def consumerLayer(cgroup: String): ZLayer[KafkaContainer with Clock , Nothing, Consumer] = | |||
There was a problem hiding this comment.
Could we write KafkaContainer & Clock instead of KafkaContainer with Clock?
|
|
||
| object Logger { | ||
|
|
||
| /* |
There was a problem hiding this comment.
What happens with logging? should we delete this object?
There was a problem hiding this comment.
logging is not yet ported to zio2
|
|
||
| object Config extends Newtype[(String, String)] | ||
| type Config = Config.Type | ||
| opaque type Config = (String, String) |
There was a problem hiding this comment.
Shouldn't we build c-tors within companion objects?
No description provided.