fix: order by function

KKould · Jan 4, 2024 · d2eb040 · d2eb040
1 parent fd5a368
commit d2eb040
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/planner/binder/order_binder.cpp b/src/planner/binder/order_binder.cpp
@@ -51,10 +51,6 @@ void OrderBinder::PushExtraExprToSelectList(ParsedExpr *expr, const SharedPtr<Bi
         return;
     }
 
-    if (expr->type_ == ParsedExprType::kFunction) {
-        return;
-    }
-
     bind_context_ptr->select_expr_name2index_[expr_name] = bind_context_ptr->select_expression_.size();
     bind_context_ptr->select_expression_.emplace_back(expr);
 }

diff --git a/test/sql/dql/sort_by_function.slt b/test/sql/dql/sort_by_function.slt
@@ -10,4 +10,12 @@ select c1, c2 from t1 order by c1 + c2, c1;
 0 1
 1 4
 2 3
-1 5
+1 5
+
+query II
+select c1, c2, c1 + c2 from t1 order by c1 + c2, c1;
+----
+0 1 1
+1 4 5
+2 3 5
+1 5 6
-Original file line number
+Diff line change
@@ Expand Up @@
             return;
         }
-        if (expr->type_ == ParsedExprType::kFunction) {
-            return;
-        }
         bind_context_ptr->select_expr_name2index_[expr_name] = bind_context_ptr->select_expression_.size();
         bind_context_ptr->select_expression_.emplace_back(expr);
     }
@@ Expand Down @@