Fix Crow package name in deb dependency definition. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechow
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Good catch!
I was aware of a potential issue with upper/lower case here, but preferred to follow Crows own CPack definition (capitalized Crow).
Interesting, that CPack converts the package name to lower-case, but not the package names of dependencies 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the dependency naming of the gui deb package.
The installed name of Crow is crow with a lower case. In the previous version, the dependency could not be resolved when installing the package via apt.
#patch