Read version from file and tag docker image in GitHub workflow #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechow
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to try the demo since it finally made it into master 🚀
I realized, that we never created the version tag for the docker images. I'm not sure if that was planned in #61 but I figured we should fix this one quickly because the current master won't work (without adjustments at least).
So this PR just adds to the workflow by reading the version from the version file and tagging the docker image we are building already. [I tested the action on this branch already])https://github.com/KIT-MRT/arbitration_graphs/actions/runs/11611034651) so we should be good to go.