Add Python bindings #105
Draft
Add Python bindings #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lent to behavior.cpp Only missing YAML features
This allows removing the sys.append hack since both the python module and the tests end up in the same directory.
Stream conversion are not supported out of the box in pybind and we would call to_str anyway.
Still missing the tests for verifiers and different sub commands
Define "wrong" type in definition. This removes some duplicated code and allows binding the type using pybind.
We need to move it to a python test where we include ag_verifier as we cannot include bindings with the different template parameters in the same python file.
Still missing the verification and different subcommand tests
This makes it possible to create a "RejectingVerifier" without creating a new Verifier class which would then require to build yet another python library
…h them in cmake. This also tidies up the CMakeLists a little bit for the python tests.
We don't need this binding an cannot even call it from python because the Node class has no bindings
…t to 1 if tests fail Otherwise ctest will not report broken tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes python bindings to use all the awesome features of the library in a python environment.
Analogously to KIT-MRT/util_caching#6, this doesn't add the bindings directly which wouldn't be possible because the arbitration graphs library is fully templated.
Instead, this adds a wrapper function that you need to call using the desired types to build a python library for them.
To make sure that everything works as expected, I translated all of the unit tests to python.
#minor