-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Uuid
from Kotlin standard library
#758
base: main
Are you sure you want to change the base?
Conversation
Awesome, thanks for this! |
5f1cb4c
to
f8b8761
Compare
@twyatt Thank you. I’ll leave it to you. I encountered some errors and did a force push. The CI is now showing as “Action required.” Could you please rerun it? |
430d7e9
to
4b5f22b
Compare
I will check the following error.
The type of UUID might have unintentionally changed Java to Kotlin. |
Run |
@ykws when you have a chance, can you rebase this onto the latest |
5baad4d
to
390ff8b
Compare
@twyatt Thank you for keeping me informed. Merged the main branch and fixed the build. CI passed successfully. Please review again. |
Pretty busy on another project at the moment, but will review soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job and thank you!
I will integrate/test this with SensorTag sample app then merge soon. |
Hi @twyatt
Although it may already be in progress, I tried switching to Kotlin UUID.
https://kotlinlang.org/docs/whatsnew2020.html#standard-library
Uuid
from Kotlin standard library #748I have modified it so that only one
@OptIn(ExperimentalUuidApi::class)
annotation is needed for the file.Please let me know any feedback.