fix(plugin-server): filter NaN out of buildIntegerMatcher (PostHog#18106

)
Justicea83 · Oct 24, 2023 · b0a5223 · b0a5223
1 parent d0fc30b
commit b0a5223
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/plugin-server/src/config/config.ts b/plugin-server/src/config/config.ts
@@ -227,14 +227,19 @@ export function overrideWithEnv(
 }
 
 export function buildIntegerMatcher(config: string | undefined, allowStar: boolean): ValueMatcher<number> {
-    // Builds a ValueMatcher on a coma-separated list of values.
+    // Builds a ValueMatcher on a comma-separated list of values.
     // Optionally, supports a '*' value to match everything
-    if (!config) {
+    if (!config || config.trim().length == 0) {
         return () => false
     } else if (allowStar && config === '*') {
         return () => true
     } else {
-        const values = new Set(config.split(',').map((n) => parseInt(n)))
+        const values = new Set(
+            config
+                .split(',')
+                .map((n) => parseInt(n))
+                .filter((num) => !isNaN(num))
+        )
         return (v: number) => {
             return values.has(v)
         }