Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose buildFeature flag could be removed after AGP 8.5.1 #1603

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jul 30, 2024

It will be enabled after org.jetbrains.kotlin.plugin.compose is applied.

@JunkFood02
Copy link
Owner

Oops! The ongoing development of seal is in the v2 branch, where I've already migrated to Kotlin 2.0. I just forgot to update the contributing docs. Thanks for bringing this up!

@JunkFood02 JunkFood02 closed this Jul 30, 2024
@JunkFood02 JunkFood02 reopened this Jul 30, 2024
@Goooler Goooler changed the base branch from main to v2 July 30, 2024 14:50
It will be enabled after `org.jetbrains.kotlin.plugin.compose` is applied.
@Goooler Goooler changed the title Migrate to Kotlin 2.0 Compose buildFeature flag could be removed after AGP 8.5.1 Jul 30, 2024
@JunkFood02
Copy link
Owner

thx!

Compose buildFeature flag could be removed after AGP 8.5.1

Do you have the changelog or a blog post refering to this?

@Goooler
Copy link
Contributor Author

Goooler commented Jul 30, 2024

之前在推上面看到的 Compose 组的人说的,找不到出处了。这个标记位是控制 Compose 预览的,之前也可以关掉,关掉就没法看到预览,现在会默认开启。

@JunkFood02 JunkFood02 merged commit 0b80936 into JunkFood02:v2 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants