Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more careful format string/quoting in validator messages #944

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Use more careful format string/quoting in validator messages #944

merged 2 commits into from
Oct 21, 2024

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Oct 21, 2024 •
edited
Loading

For example, change this (scroll to right):

Attribute "leaf_switches[\"leaf\"].mlag_info" required when "leaf_switches[\"leaf\"].redundancy_protocol" has value "\"mlag\"".

To this:

Attribute "leaf_switches[\"leaf\"].mlag_info" required when "leaf_switches[\"leaf\"].redundancy_protocol" has value "mlag".

@chrismarget-j chrismarget-j linked an issue Oct 21, 2024 that may be closed by this pull request
Eliminate extra quoting in validation error #943
Closed
@chrismarget-j chrismarget-j marked this pull request as draft October 21, 2024 15:36
@chrismarget-j chrismarget-j marked this pull request as ready for review October 21, 2024 15:38
@chrismarget-j
Copy link
Collaborator Author

Closes #943

@chrismarget-j chrismarget-j merged commit 810ee58 into main Oct 21, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the 943-eliminate-extra-quoting-in-validation-error branch October 21, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwJuniper bwJuniper bwJuniper approved these changes

@rajagopalans rajagopalans Awaiting requested review from rajagopalans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate extra quoting in validation error
2 participants
@chrismarget-j @bwJuniper