Fold obsolete getLoopbackInterfaceNode() into getLoopback0Addresses()
#938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
changed the title
getLoopbackInterfaceNode() into getLoopback0Addresses()getLoopbackInterfaceNode() into getLoopback0Addresses()
bwJuniper
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getLoopbackInterfaceNode()function was previously used for a few different purposes, which explains it's peculiar "return raw JSON" function signature.Various previous PRs mean we're only using it for one thing now: Retrieve IPv4 and IPv6 addresses.
At this point, It doesn't need to exist at all as a standalone function, let alone one so clunky that it returns raw JSON.
This PR folds that function into the only place it gets called, and cleans up some of the clunkiness associated with passing around raw JSON. The logic is (should be?) unchanged.
Closes #891