Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up obsolete version constraints #930

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Oct 18, 2024

This PR cleans up obsolete version constraints.

Obsolete here means two things:

  • incompatible with Apstra's semver behavior
  • constraints revolving around Apstra 4.1 (for which we've dropped support)

Changes in this PR:

  • eliminate old version constraints in apstra/api_versions/constraints.go
    • these used hashicorp's strict semver package
    • required introduction of FabricSettingsSetInCreate using our non-semver constraint package
  • eliminate 4.1.x constants
  • eliminate references to 4.1.x in documentation
  • eliminate 4.1.x constraints in test cases
  • eliminate 4.1.x-only test cases

Tested with:

  • 4.2.0
  • 4.2.1
  • 4.2.1.1
  • 4.2.2
  • 5.0.0

@chrismarget-j chrismarget-j linked an issue Oct 18, 2024 that may be closed by this pull request
@chrismarget-j chrismarget-j marked this pull request as draft October 18, 2024 12:59
@chrismarget-j chrismarget-j marked this pull request as ready for review October 18, 2024 17:40
@chrismarget-j chrismarget-j merged commit a416159 into main Oct 18, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the 918-old-test-case-constraints-can-be-removed branch October 18, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old test case constraints can be removed
2 participants