Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SDK version #916

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Bump SDK version #916

merged 3 commits into from
Oct 16, 2024

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Oct 10, 2024 •
edited
Loading

This PR:

  • bumps the SDK version to include
    • recent changes around port roles (iota to enum)
    • freeform system device profile ID is now a pointer (optional for external systems)
  • drops the not-as-useful-as-i-thought generic defaulter (we use the one that comes with the framework now)
  • little bit of mandatory cleanup by gofumpt

@chrismarget-j chrismarget-j linked an issue Oct 10, 2024 that may be closed by this pull request
Deprecate l3_server logical device port role for 5.x #892
Closed
@chrismarget-j chrismarget-j changed the title WIP: Bump SDK version Bump SDK version Oct 16, 2024
@chrismarget-j chrismarget-j merged commit 8170777 into main Oct 16, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the 892-deprecate-l3_server-logical-device-port-role-for-5x branch October 16, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwJuniper bwJuniper bwJuniper approved these changes

@rajagopalans rajagopalans Awaiting requested review from rajagopalans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate l3_server logical device port role for 5.x
2 participants
@chrismarget-j @bwJuniper