Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to clarify when either id or name is required input #250

Merged
merged 6 commits into from
Aug 6, 2023

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Aug 5, 2023

Most singleton data sources accept ExactlyOneOf() these optional attributes:

  • id
  • name

The documentation didn't use consistent language to describe the situation. Sometimes the requirement wasn't enumerated at all.

This PR normalizes the language across these data sources and removes the it is incumbent upon the user bit about name collisions since Apstra 4.1.2 has (mostly?) eliminated that problem.

Closes #221

@chrismarget-j chrismarget-j merged commit 8ecd8ba into main Aug 6, 2023
1 check passed
@chrismarget-j chrismarget-j deleted the task/221 branch August 6, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit singleton data sources for doc phrases like "exactly one of"
2 participants