Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Connectivity Templates #226

Merged
merged 41 commits into from
Aug 1, 2023
Merged

Add support for Connectivity Templates #226

merged 41 commits into from
Aug 1, 2023

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Jul 30, 2023 •
edited
Loading

Introduce resource apstra_datacenter_connectivity_template and helper data sources:

  • apstra_datacenter_ct_bgp_peering_generic_system
  • apstra_datacenter_ct_ip_link
  • apstra_datacenter_ct_routing_policy
  • apstra_datacenter_ct_static_route
  • apstra_datacenter_ct_virtual_network_multiple
  • apstra_datacenter_ct_virtual_network_single

Still outstanding:

  • apstra_datacenter_ct_custom_static_route
  • apstra_datacenter_ct_bgp_peering_ip_endpoint
  • apstra_datacenter_ct_dynamic_bgp_peering
  • apstra_datacenter_ct_routing_zone_constraint

A helper function in this PR required a new (standard? third party?) dependency: golang.org/x/exp/constraints. We'll be able to remove it when Go 1.21 is GA.

closes #163

@chrismarget-j
WIP connectivity template
4fe607d
@chrismarget-j
WIP: CT Create() seems to be working
b954672
@chrismarget-j
WIP: CT, introduce data source `apstra_datacenter_bgp_peering_generic…
ba73877 
…_system`
@chrismarget-j
WIP: eliminate unreachable code for benefit of the checker
6447e92
@chrismarget-j
WIP: CT fix stuff caught by linter
99468e0
@chrismarget-j
fix error string copypasta
cada7b3
@chrismarget-j
add utils.Min()
2d82cb7
@chrismarget-j
WIP: CT Create() and Read() appear to be working with handful of …
586bbdc 
…primitives
@chrismarget-j
make tfCfgPrimitive private
33f9138
@chrismarget-j
make tfCfgPrimitive.rehydrate() private
d947890
@chrismarget-j
fix format string
067166e
@chrismarget-j
change rehydrate() to take ctx, path, diags
24db2c6
@chrismarget-j
rename variable for readability
a93f110
@chrismarget-j
introduce Delete() method for resourceDatacenterConnectivityTemplate
c075964
@chrismarget-j
fix crash with non-empty tag set
05bdb51
@chrismarget-j
handle child primitives (JSON strings) as Set rather than List
b9e954d 
Apstra doesn't keep them in order. They're strings, so easy to
dereference by value. Initial testing looks fine.
@chrismarget-j
fix name of bgp_peering_generic_system CT data source
7ee5c6f
@chrismarget-j
bump SDK to get required fixes
fa3cfd0
@chrismarget-j
remove go files for un-implemented features because they block
6bfd8ec 
doc generation and cause build / test errors.
@chrismarget-j
introduce bgp generic system CT primitive; normalize earlier primitives
2717fc9
@chrismarget-j
make docs
694d564
@chrismarget-j
handle null VN Node ID in Read()
4301c5b
@chrismarget-j
bump SDK version for custom handling of 5xx errors
bad7eb5
@chrismarget-j
implement connectivity template Update() method
0791457
@chrismarget-j
skip unnecessary slice duplication
193c0bf
@chrismarget-j
update 3rd party licenses
7e0b9ef
@chrismarget-j
conditionally set CT resource ID in Request for use by both `Read()…
615fd0a 
…` and `Update()`
@chrismarget-j
CT primitives sort their children in Marshal()
83e3a93
@chrismarget-j
add support for child CT primitives to CT primitive Virtual Network S…
3a679ab 
…ingle
@chrismarget-j
make docs after adding children to vn single ct primitive
9bfcee1
@rajagopalans rajagopalans self-requested a review July 31, 2023 11:19
@chrismarget-j chrismarget-j changed the title WIP: Add support for Connectivity Templates Add support for Connectivity Templates Aug 1, 2023
@chrismarget-j chrismarget-j merged commit 44e1f3a into main Aug 1, 2023
1 check passed
@chrismarget-j chrismarget-j deleted the feat/163 branch August 1, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajagopalans rajagopalans rajagopalans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for connectivity templates
2 participants
@chrismarget-j @rajagopalans