Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #140 #199

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Fix issue #140 #199

merged 4 commits into from
Jul 19, 2023

Conversation

bwJuniper
Copy link
Collaborator

Fix issue #140

chrismarget-j
chrismarget-j requested changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@chrismarget-j chrismarget-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two files in test have vanished...

That's okay... I think the whole test directory should probably be eliminated.

Please remove the two additional now-superfluous constants?

apstra/constants.go Outdated Show resolved Hide resolved
bwJuniper
bwJuniper commented Jul 19, 2023
View reviewed changes
Copy link
Collaborator Author

@bwJuniper bwJuniper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think all changes are ok

@bwJuniper bwJuniper merged commit 3c621e2 into main Jul 19, 2023
1 check passed
@bwJuniper bwJuniper deleted the bw_issue_140 branch July 19, 2023 19:30
chrismarget-j added a commit that referenced this pull request Jul 19, 2023
@chrismarget-j
remove unnecessary test (same as \#199)
df03708
@bwJuniper bwJuniper mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismarget-j chrismarget-j chrismarget-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwJuniper @chrismarget-j