Fix issue #140

apstra/constants.go

@@ -9,13 +9,8 @@ const (
 	errResourceConfigureProviderDataSummary   = "Unexpected Resource Configure Type."
 	errResourceConfigureProviderDataDetail    = "Expected '%T', got: '%T'. Please report this issue to the provider maintainers."
 	errDataSourceUnconfiguredSummary          = "Data Source not configured"
-	errDatasourceUnconfiguredDetail           = "Unconfigured data source encountered in Read() operation, possibly because it depends on an unknown value from another object. This leads to weird stuff happening, so we'd prefer if you didn't do that. Thanks!"
 	errProviderInvalidConfig                  = "Provider configuration invalid"
 	errResourceUnconfiguredSummary            = "Resource not configured"
-	errResourceUnconfiguredCreateDetail       = "Unconfigured resource encountered in Create() operation, possibly because it depends on an unknown value from another object. This leads to weird stuff happening, so we'd prefer if you didn't do that. Thanks!"
-	errResourceUnconfiguredReadDetail         = "Unconfigured resource encountered in Read() operation, possibly because it depends on an unknown value from another object. This leads to weird stuff happening, so we'd prefer if you didn't do that. Thanks!"
-	errResourceUnconfiguredUpdateDetail       = "Unconfigured resource encountered in Update() operation, possibly because it depends on an unknown value from another object. This leads to weird stuff happening, so we'd prefer if you didn't do that. Thanks!"
-	errResourceUnconfiguredDeleteDetail       = "Unconfigured resource encountered in Delete() operation, possibly because it depends on an unknown value from another object. This leads to weird stuff happening, so we'd prefer if you didn't do that. Thanks!"
 	errReadingAllocation                      = "error reading '%s' resource allocation '%s' for Blueprint '%s'"
 	errSettingAllocation                      = "error setting resource allocation"
 	errProviderBug                            = "Provider Bug. Please report this issue to the provider maintainers."

apstra/data_source_agent.go

@@ -32,11 +32,6 @@ func (o *dataSourceAgent) Schema(_ context.Context, _ datasource.SchemaRequest,
 }
 
 func (o *dataSourceAgent) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	// Retrieve values from config.
 	var config systemAgents.ManagedDevice
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)

apstra/data_source_agent_profile.go

@@ -34,11 +34,6 @@ func (o *dataSourceAgentProfile) Schema(_ context.Context, _ datasource.SchemaRe
 }
 
 func (o *dataSourceAgentProfile) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config agentProfile
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_agent_profiles.go

@@ -48,11 +48,6 @@ func (o *dataSourceAgentProfiles) Schema(_ context.Context, _ datasource.SchemaR
 }
 
 func (o *dataSourceAgentProfiles) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	config := struct {
 		Ids            types.Set    `tfsdk:"ids"`
 		Platform       types.String `tfsdk:"platform"`

apstra/data_source_agents.go

@@ -47,11 +47,6 @@ func (o *dataSourceAgents) Schema(_ context.Context, _ datasource.SchemaRequest,
 }
 
 func (o *dataSourceAgents) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	type systems struct {
 		IDs     types.Set    `tfsdk:"ids"`
 		Filters types.Object `tfsdk:"filters"`

apstra/data_source_anomalies.go

@@ -32,11 +32,6 @@ func (o *dataSourceAnomalies) Schema(_ context.Context, _ datasource.SchemaReque
 }
 
 func (o *dataSourceAnomalies) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprint.Anomalies
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_asn_pool.go

@@ -37,11 +37,6 @@ func (o *dataSourceAsnPool) Schema(_ context.Context, _ datasource.SchemaRequest
 }
 
 func (o *dataSourceAsnPool) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config resources.AsnPool
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_asn_pools.go

@@ -36,11 +36,6 @@ func (o *dataSourceAsnPools) Schema(_ context.Context, _ datasource.SchemaReques
 }
 
 func (o *dataSourceAsnPools) Read(ctx context.Context, _ datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	ids, err := o.client.ListAsnPoolIds(ctx)
 	if err != nil {
 		resp.Diagnostics.AddError("Error retrieving ASN Pool IDs", err.Error())

apstra/data_source_blueprint_deployment.go

@@ -31,11 +31,6 @@ func (o *dataSourceBlueprintDeploy) Schema(_ context.Context, _ datasource.Schem
 }
 
 func (o *dataSourceBlueprintDeploy) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprint.Deploy
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_blueprints.go

@@ -80,11 +80,6 @@ func (o *dataSourceBlueprints) ValidateConfig(ctx context.Context, req datasourc
 }
 
 func (o *dataSourceBlueprints) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprints
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_configlet.go

@@ -35,11 +35,6 @@ func (o *dataSourceConfiglet) Schema(_ context.Context, _ datasource.SchemaReque
 }
 
 func (o *dataSourceConfiglet) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config design.Configlet
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_configlets.go

@@ -50,11 +50,6 @@ func (o *dataSourceConfiglets) Schema(_ context.Context, _ datasource.SchemaRequ
 }
 
 func (o *dataSourceConfiglets) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config struct {
 		Ids                types.Set `tfsdk:"ids"`
 		SupportedPlatforms types.Set `tfsdk:"supported_platforms"`

apstra/data_source_datacenter_blueprint.go

@@ -36,11 +36,6 @@ func (o *dataSourceDatacenterBlueprint) Schema(_ context.Context, _ datasource.S
 }
 
 func (o *dataSourceDatacenterBlueprint) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprint.Blueprint
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_datacenter_property_set.go

@@ -34,11 +34,6 @@ func (o *dataSourceDatacenterPropertySet) Schema(_ context.Context, _ datasource
 }
 
 func (o *dataSourceDatacenterPropertySet) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprint.DatacenterPropertySet
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_datacenter_property_sets.go

@@ -46,11 +46,6 @@ func (o *dataSourceDatacenterPropertySets) Schema(_ context.Context, _ datasourc
 }
 
 func (o *dataSourceDatacenterPropertySets) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config struct {
 		BlueprintId types.String `tfsdk:"blueprint_id"`
 		Ids         types.Set    `tfsdk:"ids"`

apstra/data_source_datacenter_routing_zone.go

@@ -32,11 +32,6 @@ func (o *dataSourceDatacenterRoutingZone) Schema(_ context.Context, _ datasource
 }
 
 func (o *dataSourceDatacenterRoutingZone) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	// Retrieve values from config.
 	var config blueprint.DatacenterRoutingZone
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)

apstra/data_source_datacenter_routing_zones.go

@@ -56,11 +56,6 @@ func (o *dataSourceDatacenterRoutingZones) Schema(_ context.Context, _ datasourc
 }
 
 func (o *dataSourceDatacenterRoutingZones) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	type routingZones struct {
 		BlueprintId types.String `tfsdk:"blueprint_id"`
 		IDs         types.Set    `tfsdk:"ids"`

apstra/data_source_datacenter_system.go

@@ -32,11 +32,6 @@ func (o *dataSourceDatacenterSystemNode) Schema(_ context.Context, _ datasource.
 }
 
 func (o *dataSourceDatacenterSystemNode) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprint.NodeTypeSystem
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_datacenter_systems.go

@@ -31,11 +31,6 @@ func (o *dataSourceDatacenterSystemNodes) Schema(_ context.Context, _ datasource
 }
 
 func (o *dataSourceDatacenterSystemNodes) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprint.NodesTypeSystem
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_datacenter_virtual_network_binding_constructor.go

@@ -37,11 +37,6 @@ func (o *dataSourceVirtualNetworkBindingConstructor) Schema(_ context.Context, _
 }
 
 func (o *dataSourceVirtualNetworkBindingConstructor) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config blueprint.VnBindingConstructor
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_interface_map.go

@@ -37,11 +37,6 @@ func (o *dataSourceInterfaceMap) Schema(_ context.Context, _ datasource.SchemaRe
 }
 
 func (o *dataSourceInterfaceMap) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config design.InterfaceMap
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_interface_maps.go

@@ -50,11 +50,6 @@ func (o *dataSourceInterfaceMaps) Schema(_ context.Context, _ datasource.SchemaR
 }
 
 func (o *dataSourceInterfaceMaps) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config interfaceMaps
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_ipv4_pool.go

@@ -36,11 +36,6 @@ func (o *dataSourceIpv4Pool) Schema(_ context.Context, _ datasource.SchemaReques
 }
 
 func (o *dataSourceIpv4Pool) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config resources.Ipv4Pool
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_ipv4_pools.go

@@ -36,11 +36,6 @@ func (o *dataSourceIpv4Pools) Schema(_ context.Context, _ datasource.SchemaReque
 }
 
 func (o *dataSourceIpv4Pools) Read(ctx context.Context, _ datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	ids, err := o.client.ListIp4PoolIds(ctx)
 	if err != nil {
 		resp.Diagnostics.AddError("Error retrieving IPv4 Pool IDs", err.Error())

apstra/data_source_ipv6_pool.go

@@ -36,11 +36,6 @@ func (o *dataSourceIpv6Pool) Schema(_ context.Context, _ datasource.SchemaReques
 }
 
 func (o *dataSourceIpv6Pool) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config resources.Ipv6Pool
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_ipv6_pools.go

@@ -36,11 +36,6 @@ func (o *dataSourceIpv6Pools) Schema(_ context.Context, _ datasource.SchemaReque
 }
 
 func (o *dataSourceIpv6Pools) Read(ctx context.Context, _ datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	ids, err := o.client.ListIp6PoolIds(ctx)
 	if err != nil {
 		resp.Diagnostics.AddError("Error retrieving IPv6 Pool IDs", err.Error())

apstra/data_source_logical_device.go

@@ -37,11 +37,6 @@ func (o *dataSourceLogicalDevice) Schema(_ context.Context, _ datasource.SchemaR
 }
 
 func (o *dataSourceLogicalDevice) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config design.LogicalDevice
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_property_set.go

@@ -35,11 +35,6 @@ func (o *dataSourcePropertySet) Schema(_ context.Context, _ datasource.SchemaReq
 }
 
 func (o *dataSourcePropertySet) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config design.PropertySet
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_property_sets.go

@@ -36,11 +36,6 @@ func (o *dataSourcePropertySets) Schema(_ context.Context, _ datasource.SchemaRe
 }
 
 func (o *dataSourcePropertySets) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config struct {
 		Ids types.Set `tfsdk:"ids"`
 	}

apstra/data_source_rack_type.go

@@ -37,11 +37,6 @@ func (o *dataSourceRackType) Schema(_ context.Context, _ datasource.SchemaReques
 }
 
 func (o *dataSourceRackType) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config design.RackType
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_rack_types.go

@@ -36,11 +36,6 @@ func (o *dataSourceRackTypes) Schema(_ context.Context, _ datasource.SchemaReque
 }
 
 func (o *dataSourceRackTypes) Read(ctx context.Context, _ datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	ids, err := o.client.ListRackTypeIds(ctx)
 	if err != nil {
 		resp.Diagnostics.AddError("Error retrieving Rack Type IDs", err.Error())

apstra/data_source_tag.go

@@ -35,11 +35,6 @@ func (o *dataSourceTag) Schema(_ context.Context, _ datasource.SchemaRequest, re
 }
 
 func (o *dataSourceTag) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config design.Tag
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {

apstra/data_source_template_rack_based.go

@@ -36,11 +36,6 @@ func (o *dataSourceTemplateRackBased) Schema(_ context.Context, _ datasource.Sch
 }
 
 func (o *dataSourceTemplateRackBased) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
-	if o.client == nil {
-		resp.Diagnostics.AddError(errDataSourceUnconfiguredSummary, errDatasourceUnconfiguredDetail)
-		return
-	}
-
 	var config design.TemplateRackBased
 	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
 	if resp.Diagnostics.HasError() {