-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1229 #1230
base: master
Are you sure you want to change the base?
Fix for #1229 #1230
Conversation
Pushed a commit with black format. |
I pushed this commit to fix the pylint failing but that doesn't seems to reflect here in this PR. 31d7aee. Any idea why it's not showing up here. |
@Aaron-MJohn I see this error for the link you have provided above - This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository. Also check the build failures |
I forked this repo and made a branch and created pull request from that branch to this repo. |
@Aaron-MJohn, your 3rd commit still needs to be pushed here. It is visible in your fork. The pull request shows only two commits. The build is failing for the black tool, and I believe your 3rd commit will address it. |
Hi @Aaron-MJohn Thanks |
Thank you, I have pushed the changes. |
25577e0
to
66ce164
Compare
@chidanandpujar can you approve the workflow. |
Hi @Aaron-MJohn Thanks |
Pushed fix for test. @chidanandpujar can you approve the workflow? |
Hi @Aaron-MJohn Thanks |
Executed Functional tests , all the tests looks to be working fine ..
|
@chidanandpujar can you approve workflow? |
Hi @Aaron-MJohn Thanks |
Hey, I assume this is what you asked for
#without password
#with wrong password
|
Thanks very much for sharing the logs . |
Hi @Aaron-MJohn Thanks |
Hi @Aaron-MJohn Thanks |
I ran unit test and all passed except one test failing in master branch
|
Fix for #1229
Read the whole buffer and get the last keyword.