Update macos app bundle id

Juniper · Oct 17, 2024 · 762c4fe · 762c4fe
1 parent 5d1a711
commit 762c4fe
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 14 deletions.
diff --git a/jccm/forge.config.js b/jccm/forge.config.js
@@ -10,6 +10,7 @@ let archOption;
 
 module.exports = {
     packagerConfig: {
+        appBundleId: 'net.juniper.juniper-cloud-connection-manager',
         asar: true,
         icon: './assets/icons/AppIcon', // Path without the extension
         osxSign: {
@@ -49,11 +50,14 @@ module.exports = {
                 format: 'ULFO', // Optional: Customize DMG format
                 overwrite: true,
             },
-        },        
+        },
         {
             name: '@electron-forge/maker-squirrel',
             config: {
-                iconUrl: `file://${path.resolve(__dirname, 'assets/icons/AppIcon.ico')}`, // Local file URL for Windows
+                iconUrl: `file://${path.resolve(
+                    __dirname,
+                    'assets/icons/AppIcon.ico'
+                )}`, // Local file URL for Windows
                 setupIcon: path.join(__dirname, 'assets/icons/AppIcon.ico'), // Path to the .ico file for Windows
                 overwrite: true,
                 out: path.join(__dirname, 'out/make/windows-x64'),
@@ -95,8 +99,12 @@ module.exports = {
             archOption = arch ? arch : process.arch;
         },
         preMake: async (config) => {
-            const makerPkg = config.makers.find((maker) => maker.name === '@electron-forge/maker-pkg');
-            const makerDmg = config.makers.find((maker) => maker.name === '@electron-forge/maker-dmg');
+            const makerPkg = config.makers.find(
+                (maker) => maker.name === '@electron-forge/maker-pkg'
+            );
+            const makerDmg = config.makers.find(
+                (maker) => maker.name === '@electron-forge/maker-dmg'
+            );
 
             const name = `jccm-darwin-${archOption}`;
 

diff --git a/jccm/package-lock.json b/jccm/package-lock.json
diff --git a/jccm/package.json b/jccm/package.json
@@ -3,15 +3,6 @@
     "productName": "Juniper Cloud Connection Manager",
     "description": "Juniper Cloud Connection Manager",
     "version": "1.2.3",
-    "build": {
-        "publish": [
-            {
-                "provider": "github",
-                "owner": "simonrho",
-                "repo": "juniper-jccm"
-            }
-        ]
-    },
     "main": ".webpack/main",
     "scripts": {
         "start": "pkill -9 node; nodemon --watch ./src --ext js,json --ignore ./src/Frontend/ --exec 'electron-forge start'",
@@ -92,6 +83,7 @@
         "socket.io-client": "^4.7.5",
         "ssh2": "^1.15.0",
         "tough-cookie": "^4.1.4",
+        "update-electron-app": "^3.0.0",
         "uuid": "^9.0.1",
         "validator": "^13.12.0",
         "xlsx": "^0.18.5",

diff --git a/jccm/src/main.js b/jccm/src/main.js
@@ -51,14 +51,14 @@ const createWindow = () => {
     console.log('Window Created');
 };
 
-
 // This method will be called when Electron has finished
 // initialization and is ready to create browser windows.
 // Some APIs can only be used after this event occurs.
 app.whenReady().then(() => {
     setupApiHandlers(); // Set up IPC handlers
     createWindow();
 
+
     // On OS X it's common to re-create a window in the app when the
     // dock icon is clicked and there are no other windows open.
     app.on('activate', () => {