updated lfm discovery state enums and trigger msg #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaddevijay
requested changes
Jul 31, 2024
| enumerate "Send Local Remote Ok" as 3; | ||
| enumerate "Fault" as -1; | ||
| enumerate "Active Send Local" as 3; | ||
| enumerate "Passive Wait" as 4; |
There was a problem hiding this comment.
Do not change enums for already present states
There was a problem hiding this comment.
Also can you confirm that state anything > 1 is a good state?
gaddevijay
requested changes
Jul 31, 2024
| @@ -67,15 +85,15 @@ healthbot { | |||
| then { | |||
| status { | |||
| color green; | |||
| message "$lfm-interface-name LFM discovery-state: $lfm-discovery-state; lfm-status: $lfm-status; lfm-peer-address: $lfm-peer-address"; | |||
| message "$lfm-interface-name LFM discovery-state: $lfm-discovery-state; lfm-status: $lfm-status"; | |||
There was a problem hiding this comment.
If peer address is not used anywhere can we remove the field? Please confirm with Venakt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated enums as per the below link https://opengrok.juniper.net/source/xref/DEV_COMMON_BRANCH/junos/usr.sbin/lfmd/lfmd_discovery.c?r=1178985#291